flat-fuchsia
flat-fuchsia3y ago

Overriding default padding of 'main' area

Sorry for all the noob questions but what is the 'correct' way to override the default padding of the main area? I could nuke the css but if there's a non-hacky way that would be better.
No description
No description
17 Replies
flat-fuchsia
flat-fuchsiaOP3y ago
Also, can you make the Box area fill the entire main area too regardless of content?
Omer
Omer3y ago
Hey @jn , You can easily override the Layout, here is the documentation on how to do it ⚡ https://refine.dev/docs/api-reference/mui/customization/mui-custom-layout/#creating-a-custom-layout Layout component: https://github.com/pankod/refine/blob/next/packages/mui/src/components/layout/index.tsx sorry, I don't fully understand this but can @core help us?
flat-fuchsia
flat-fuchsiaOP3y ago
@Omer Thanks Omer. I think that's what I want. I thought adding a new layout would be more complicated, but it seems straightforward! I am getting an issue trying to import the default header. I can see the Header being exported in the node_modules same as the Sider which is strange...
No description
Omer
Omer3y ago
I'm checking Ups apparently we forgot to export 🙂 Would you like to fix this as part of the Hactoberfest (https://refine.dev/blog/hacktoberfest-refine/) event? https://github.com/pankod/refine/blob/next/packages/mui/src/components/index.tsx#L2
flat-fuchsia
flat-fuchsiaOP3y ago
Ah okay. Is there an issue for this already or would it need raising?
Omer
Omer3y ago
You can create a new one, we will label it "hackoberfest"
flat-fuchsia
flat-fuchsiaOP3y ago
GitHub
[BUG] Unable to import Header component from @pankod/refine-mui · I...
Describe the bug When trying to import the Header component from @pankod/refine-mui into a CustomLayout I am getting the following error. Module '"@pankod/refine-mui"&...
Omer
Omer3y ago
🚀
flat-fuchsia
flat-fuchsiaOP3y ago
@Omer Just to check as I couldn't see it in the Contributing page. Do I just create branch from next, make the changes and then raise a PR? Does the branch need to be named with a particular format or anything like that?
Omer
Omer3y ago
this might be the document you are looking for, https://refine.dev/docs/contributing/
Contributing | refine
We follow a code of conduct when participating in the community. Please read it before you make any contributions.
flat-fuchsia
flat-fuchsiaOP3y ago
Apologies, that's the page I was looking at. I just meant that it doesn't mention what to branch from, what to name a branch, etc. It might be worth adding a section on that for people new to open source projects (like me).
Omer
Omer3y ago
That would be great! You can create a branch from the next branch. We do not follow a convention in branch naming. You are free in this matter. If you wish, you can also contribute to this document 🆙
flat-fuchsia
flat-fuchsiaOP3y ago
@Omer Do I need permissions to create the branch in your repo?
No description
Omer
Omer3y ago
The correct way to do this is to create a Fork PR. There is a little tutorial here, https://www.tomasbeuzen.com/post/git-fork-branch-pull/
Tomas Beuzen
The Git Fork-Branch-Pull Workflow | Tomas Beuzen
A simple summary of how to collaborate on open-source projects using forking, branching and pull requests.
flat-fuchsia
flat-fuchsiaOP3y ago
@Omer I've raised the PR. Thanks for the all the help, much appreciated.
Omer
Omer3y ago
Congrats, we'll release it soon 🚀 Btw don't forget to support us by starring refine on GitHub ⚡️ Hey @jn , We've released @pankod/refine-mui@3.48.2. Could you approve fix?