deep-jade
deep-jade8mo ago

onFinish, being sent as object instead of input

I'm using onFinish to pass input, but it's being sent as an object, how can i change this?
11 Replies
kapa.ai
kapa.ai8mo ago
Hi @Konungariket Sverige. I'm kapa.ai, your friendly support bot. I will try to answer your question by searching through the knowledge base. :wave: ---------------------- Based on the information provided in the extracts, it seems you're encountering an issue where the data you're trying to send through the onFinish function is not being formatted as expected when submitted. This issue might be related to how you're structuring the data within the onFinish function. In one of the extracts from the documentation regarding the useForm hook in the context of React Hook Form, there's an example showing how to modify form data before it's submitted to the API. This example demonstrates combining two separate input values (name and surname) into a single fullName property before submission:
import { useForm } from "@refinedev/react-hook-form";
import React from "react";
import { FieldValues } from "react-hook-form";

export const UserCreate: React.FC = () => {
const {
refineCore: { onFinish },
register,
handleSubmit,
} = useForm();

const onFinishHandler = (data: FieldValues) => {
onFinish({
fullName: `${data.name} ${data.surname}`,
});
};

return (
<form onSubmit={handleSubmit(onFinishHandler)}>
<label>Name: </label>
<input {...register("name")} />
<br />

<label>Surname: </label>
<input {...register("surname")} />
<br />

<button type="submit">Submit</button>
</form>
);
};
import { useForm } from "@refinedev/react-hook-form";
import React from "react";
import { FieldValues } from "react-hook-form";

export const UserCreate: React.FC = () => {
const {
refineCore: { onFinish },
register,
handleSubmit,
} = useForm();

const onFinishHandler = (data: FieldValues) => {
onFinish({
fullName: `${data.name} ${data.surname}`,
});
};

return (
<form onSubmit={handleSubmit(onFinishHandler)}>
<label>Name: </label>
<input {...register("name")} />
<br />

<label>Surname: </label>
<input {...register("surname")} />
<br />

<button type="submit">Submit</button>
</form>
);
};
(Source: React Hook Form - How can I change the form data before submitting it to the API? (https://refine.dev/docs/packages/react-hook-form/use-form#how-can-i-change-the-form-data-before-submitting-it-to-the-api)) This example illustrates how you can manipulate the data within the onFinish function by creating a new object with the desired structure. If your data is being sent as an object instead of the expected format, you might need to adjust how you're constructing this object within the onFinish handler. Ensure that the structure of the object you're passing to onFinish matches the expected format of your API endpoint. If you're dealing with a more complex scenario, such as a dynamic form or a form with nested data structures, you might need to perform additional data manipulation to achieve the desired format. The key is to tailor the object you're passing to onFinish to fit the requirements of your backend API. Unfortunately, without more specific details about the structure of your form and the expected API payload, I can't provide a more tailored solution. However, the principle demonstrated in the provided example should guide you in modifying your onFinish handler to correctly format the data before submission. ---------------------- Note: you can ask me a follow up question by @ mentioning me again :speech_balloon: ----------------------
kapa.ai
kapa.ai8mo ago
<@309676512054083584> kapa.ai is still learning and improving, please let us know how it did by reacting below
deep-jade
deep-jade8mo ago
@kapa.ai This is part of the problem giving me problems <Form {...formProps} layout="vertical" onFinish={async (values) => { try { const data = await onFinish({ name: values.name, salesOwnerId: values.salesOwnerId, }); const createdCompany = (data as CreateResponse<Company>)?.data; if ((values.contacts ?? [])?.length > 0) { await createManyMutateAsync({ resource: "contacts", values: values.contacts?.map((contact) => ({ ...contact, companyId: createdCompany.id, salesOwnerId: createdCompany.users.id, })) ?? [], successNotification: false, }); } go({ to: searchParams.get("to") ?? pathname, query: { companyId: createdCompany.id, to: undefined, }, options: { keepQuery: true, }, type: "replace", }); } catch (error) { Promise.reject(error); } }} >
kapa.ai
kapa.ai8mo ago
Let me check the knowledge base for you. One moment! :books: ---------------------- Based on the provided code snippet and the context of your question, it seems you're trying to handle form submission using the onFinish function within a <Form> component in Refine. Your goal is to submit form data, potentially modify it, and then handle related operations like creating additional records based on the form's input. Unfortunately, the extracts provided do not contain a direct example or solution that matches the specific scenario you've described. The extracts mainly discuss how to modify form data before submission using the onFinish function in various contexts (e.g., with React Hook Form, Ant Design, etc.), but they don't cover complex scenarios involving asynchronous operations, handling related records, or navigating after submission as your code snippet does. However, based on the principles extracted from the documentation and the pattern in your code, here's a general approach you might consider: 1. Modify Form Data Before Submission: Use the onFinish function to modify the form data before it's submitted. This is demonstrated in the extracts where form data is manipulated (e.g., combining name and surname into fullName). 2. Perform Asynchronous Operations: Your code snippet already includes an asynchronous onFinish handler that performs additional operations after the initial form submission, such as creating related records. This pattern is consistent with the idea of using onFinish for complex submission logic. 3. Error Handling: Your snippet includes a try-catch block for error handling, which is a good practice when dealing with asynchronous operations. 4. Navigation After Submission: Your code also handles navigation after the form submission and related operations are complete. This is a common requirement in form handling scenarios. While the specific details of implementing these steps depend on your application's requirements and the structure of your API, the general approach outlined above should be applicable. If you're looking for more detailed examples or documentation on handling complex form submission scenarios in Refine, I recommend checking the official Refine documentation or community resources for more specific guides or examples. Since I can't provide a more specific solution based on the extracts, for detailed guidance on handling complex form submissions, including asynchronous operations and navigation, please refer to the Refine documentation: Refine Docs (https://refine.dev/docs/). Remember, the key to handling complex form submissions in Refine is to leverage the flexibility of the onFinish function to implement your custom logic, whether it's modifying form data, performing additional API requests, or navigating within your application. ---------------------- Note: you can ask me a follow up question by @ mentioning me again :speech_balloon: ----------------------
kapa.ai
kapa.ai8mo ago
<@309676512054083584> kapa.ai is still learning and improving, please let us know how it did by reacting below
deep-jade
deep-jade8mo ago
@kapa.ai Could i somehow not use the onFinish and submit it correctly as input?
kapa.ai
kapa.ai8mo ago
Let me check the knowledge base for you. One moment! :books: ---------------------- Based on the information provided in the extracts, it seems you're looking for a way to handle form submission without directly using the onFinish method, but still want to ensure the data is submitted correctly as input. In the context of Refine and Ant Design, which the extracts are focused on, the onFinish method is a crucial part of handling form submissions. It is designed to be used when a form is submitted, allowing you to define exactly how the form data should be handled, including any modifications or additional processing before sending the data to an API or another part of your application. However, if you're looking to handle form submission in a different way while still using Refine and Ant Design, you might consider a couple of alternative approaches based on the principles discussed in the extracts: 1. Manual Form Submission Handling: Instead of relying on the onFinish method, you could manually handle the form submission using a custom button and event handler. This approach would involve using a standard button (not the submit type) and attaching an onClick event handler where you manually gather form values, potentially modify them, and then perform the submission logic. 2. Use of useForm Hook for Custom Submission Logic: While the onFinish method is a part of the useForm hook's return values, you could leverage other aspects of the hook to implement custom submission logic. For example, you could use the form instance (form) to manually trigger form validation and submission from a custom function. Unfortunately, the extracts do not provide a specific example of submitting a form without using the onFinish method directly. The onFinish method is highlighted as the primary way to handle form submissions within the context of Refine's integration with Ant Design. Given the constraints and the focus on using Refine and Ant Design, it's important to consider that deviating from the recommended patterns (such as using onFinish for form submissions) might require more custom implementation and could potentially complicate your application's form handling logic. For more detailed guidance or alternative approaches specific to Refine and Ant Design, I recommend consulting the official documentation or community resources. The Refine documentation is a valuable resource for understanding the framework's capabilities and best practices: Refine Docs (https://refine.dev/docs/). In summary, while the onFinish method is the standard way to handle form submissions in Refine with Ant Design, alternative approaches would likely involve more manual handling of form data and submission logic, which might not be directly covered in the provided extracts. ---------------------- Note: you can ask me a follow up question by @ mentioning me again :speech_balloon: ----------------------
kapa.ai
kapa.ai8mo ago
<@309676512054083584> kapa.ai is still learning and improving, please let us know how it did by reacting below
deep-jade
deep-jade8mo ago
@kapa.ai The problem is that the input is being passed as an object, which is not accepted {,…} operationName : "CreateCompany" query : "mutation CreateCompany($input: companies_insert_input!) {\n createOneCompany(input: $input) {\n id\n name\n users {\n id\n name\n avatarUrl\n }\n }\n}\n" variables : {object: {name: "martin olsson", salesOwnerId: 1}} object : {name: "martin olsson", salesOwnerId: 1} name : "martin olsson" salesOwnerId : 1 { "errors": [ { "message": "expecting a value for non-nullable variable: "input"", "extensions": { "path": "$", "code": "validation-failed" } } ] }
kapa.ai
kapa.ai8mo ago
Let me check the knowledge base for you. One moment! :books: ---------------------- Based on the problem description and the error message you've shared, it appears that the issue lies in how the GraphQL mutation is structured and how the variables are being passed to it. The error message indicates that the GraphQL server expects a variable named input for the mutation CreateCompany, but it seems that the variable is not being passed correctly. The error message:
"errors": [
{
"message": "expecting a value for non-nullable variable: \"input\"",
"extensions": {
"path": "$",
"code": "validation-failed"
}
}
]
"errors": [
{
"message": "expecting a value for non-nullable variable: \"input\"",
"extensions": {
"path": "$",
"code": "validation-failed"
}
}
]
suggests that the mutation expects an input variable that is not nullable, but it's not receiving it as expected. Given the information provided, it looks like the variables for the mutation are structured incorrectly. The mutation expects an input variable, but instead, an object with the properties directly inside the variables object is being passed. To resolve this issue, you need to adjust how you're structuring the variables for the mutation. Specifically, you need to ensure that the variables object contains an input field that itself contains the data you want to pass to the mutation. Here's how you might adjust the variables object:
{
"variables": {
"input": {
"name": "martin olsson",
"salesOwnerId": 1
}
}
}
{
"variables": {
"input": {
"name": "martin olsson",
"salesOwnerId": 1
}
}
}
This structure correctly nests the data (name and salesOwnerId) within an input object, which matches what the mutation expects based on the error message. Unfortunately, none of the extracts provided directly address this specific issue with GraphQL mutations and variable structuring. However, understanding how to structure variables for GraphQL mutations is crucial when working with GraphQL APIs, and the error message provides a clear indication of what needs to be fixed. For more detailed information on working with GraphQL mutations and variable structuring, I recommend consulting the GraphQL documentation or resources specific to the GraphQL client library you're using, as the provided extracts do not contain links or further guidance on this topic. ---------------------- Note: you can ask me a follow up question by @ mentioning me again :speech_balloon: ----------------------
kapa.ai
kapa.ai8mo ago
<@309676512054083584> kapa.ai is still learning and improving, please let us know how it did by reacting below